[lldp-devel] [PATCH 2/2] vdptest: add additional notes to man page

Thomas-Mich Richter tmricht at linux.vnet.ibm.com
Thu Nov 14 09:21:13 UTC 2013


On 11/13/2013 10:10 PM, Philbert Lin wrote:
> Some aspects to vdptest are not intuitive. The examples at the bottom of
> the man page give the impression that vdptest maintains state throughout
> calls. Additionally the expected return code causes confusion when
> testing out the listed commands. Notes have been added to clarify.
> 
> Signed-off-by: Philbert Lin <philbert.lin at intel.com>
> ---
>  test/vdptest.1 | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/test/vdptest.1 b/test/vdptest.1
> index dcdd8ae..5f1a1b9 100644
> --- a/test/vdptest.1
> +++ b/test/vdptest.1
> @@ -89,6 +89,9 @@ terminates.
>  .br
>  .B vdptest
>  should be used for testing and debug purposes only.
> +It should be noted that there is no state stored in vdptest between calls, but
> +will be stored in lldpad (until the process restarts).
> +A profile must be created and acted upon on in the same vdptest command.
>  .SS Profiles
>  .br
>  Profile is a comma separated list of key '=' value
> @@ -492,7 +495,9 @@ Use the VSI definition named
>  .I unknown
>  and send an ASSOCIATION command to the switch.
>  Wait up to 10 seconds for the status confirmation 2
> -times and expected the error code 3 from the switch.
> +times and expected the error code 3 from the switch
> +(NOTE that this will cause vdptest to return FAILURE under
> +normal conditions).
>  Wait one second before termintation.
>  .sp 1
>  .EX
> 
Fine with me.

-- 
Thomas Richter, Dept 3250, IBM LTC Boeblingen, Data Center Networking
--
Vorsitzende des Aufsichtsrats: Martina Koederitz 
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294



More information about the lldp-devel mailing list